/backend/internal/services/system_image_setting_service_test.go

package services

import (
	"testing"

	"clawreef/internal/models"
)

type stubSystemImageSettingRepository struct {
	items  []models.SystemImageSetting
	nextID int
}

func (r *stubSystemImageSettingRepository) List() ([]models.SystemImageSetting, error) {
	out := make([]models.SystemImageSetting, len(r.items))
	copy(out, r.items)
	return out, nil
}

func (r *stubSystemImageSettingRepository) GetByID(id int) (*models.SystemImageSetting, error) {
	for _, item := range r.items {
		if item.ID == id {
			copyItem := item
			return &copyItem, nil
		}
	}
	return nil, nil
}

func (r *stubSystemImageSettingRepository) ListByInstanceType(instanceType string) ([]models.SystemImageSetting, error) {
	var out []models.SystemImageSetting
	for _, item := range r.items {
		if item.InstanceType == instanceType {
			out = append(out, item)
		}
	}
	return out, nil
}

func (r *stubSystemImageSettingRepository) Save(setting *models.SystemImageSetting) error {
	if setting.ID > 0 {
		for i := range r.items {
			if r.items[i].ID == setting.ID {
				r.items[i] = *setting
				return nil
			}
		}
	}

	r.nextID++
	copyItem := *setting
	copyItem.ID = r.nextID
	*setting = copyItem
	r.items = append(r.items, copyItem)
	return nil
}

func (r *stubSystemImageSettingRepository) DeleteByID(id int) error {
	filtered := r.items[:0]
	for _, item := range r.items {
		if item.ID != id {
			filtered = append(filtered, item)
		}
	}
	r.items = filtered
	return nil
}

func (r *stubSystemImageSettingRepository) DeleteByInstanceType(instanceType string) error {
	filtered := r.items[:0]
	for _, item := range r.items {
		if item.InstanceType != instanceType {
			filtered = append(filtered, item)
		}
	}
	r.items = filtered
	return nil
}

func TestSystemImageSettingServiceListAllowsMultipleImagesPerType(t *testing.T) {
	repo := &stubSystemImageSettingRepository{
		items: []models.SystemImageSetting{
			{ID: 1, InstanceType: "openclaw", DisplayName: "OpenClaw Stable", Image: "registry/openclaw:stable", IsEnabled: true},
			{ID: 2, InstanceType: "openclaw", DisplayName: "OpenClaw Canary", Image: "registry/openclaw:canary", IsEnabled: true},
			{ID: 3, InstanceType: "ubuntu", DisplayName: "Ubuntu Desktop", Image: "lscr.io/linuxserver/webtop:ubuntu-xfce", IsEnabled: false},
		},
		nextID: 3,
	}

	service := NewSystemImageSettingService(repo)
	items, err := service.List()
	if err != nil {
		t.Fatalf("List returned error: %v", err)
	}

	openClawCount := 0
	for _, item := range items {
		if item.InstanceType == "openclaw" {
			openClawCount++
		}
	}

	if openClawCount != 2 {
		t.Fatalf("expected 2 openclaw runtime images, got %d", openClawCount)
	}
}

func TestSystemImageSettingServiceDeleteByIDCreatesDisabledFallback(t *testing.T) {
	repo := &stubSystemImageSettingRepository{
		items: []models.SystemImageSetting{
			{ID: 1, InstanceType: "openclaw", DisplayName: "OpenClaw Stable", Image: "registry/openclaw:stable", IsEnabled: true},
		},
		nextID: 1,
	}

	service := NewSystemImageSettingService(repo)
	if err := service.DeleteByID(1); err != nil {
		t.Fatalf("DeleteByID returned error: %v", err)
	}

	items, err := repo.ListByInstanceType("openclaw")
	if err != nil {
		t.Fatalf("ListByInstanceType returned error: %v", err)
	}
	if len(items) != 1 {
		t.Fatalf("expected 1 fallback row after deleting last image, got %d", len(items))
	}
	if items[0].IsEnabled {
		t.Fatalf("expected fallback row to be disabled")
	}

	selection, ok := service.GetRuntimeImage("openclaw")
	if ok || selection.Image != "" {
		t.Fatalf("expected runtime image lookup to be disabled after fallback, got %q %v", selection.Image, ok)
	}
}

func TestSystemImageSettingServiceGetRuntimeImageFallsBackToDefaultWhenNoRowsExist(t *testing.T) {
	service := NewSystemImageSettingService(&stubSystemImageSettingRepository{})

	selection, ok := service.GetRuntimeImage("openclaw")
	if !ok {
		t.Fatalf("expected default openclaw runtime image to be available")
	}
	if selection.Image != defaultSystemImageSettings["openclaw"] {
		t.Fatalf("expected default openclaw image %q, got %q", defaultSystemImageSettings["openclaw"], selection.Image)
	}
	if selection.RuntimeType != "desktop" {
		t.Fatalf("expected default openclaw runtime type desktop, got %q", selection.RuntimeType)
	}
}

func TestSystemImageSettingServiceListIncludesOpenClawShellDefault(t *testing.T) {
	service := NewSystemImageSettingService(&stubSystemImageSettingRepository{})

	items, err := service.List()
	if err != nil {
		t.Fatalf("List returned error: %v", err)
	}

	found := false
	for _, item := range items {
		if item.InstanceType == "openclaw" && item.RuntimeType == "shell" {
			found = true
			if item.Image != defaultShellSystemImageSettings["openclaw"] {
				t.Fatalf("expected default openclaw shell image %q, got %q", defaultShellSystemImageSettings["openclaw"], item.Image)
			}
			if !item.IsEnabled {
				t.Fatalf("expected default openclaw shell image to be enabled")
			}
		}
	}

	if !found {
		t.Fatalf("expected default openclaw shell runtime image")
	}
}

func TestSystemImageSettingServiceGetRuntimeImageForImageFallsBackToOpenClawShellDefault(t *testing.T) {
	service := NewSystemImageSettingService(&stubSystemImageSettingRepository{})

	selection, ok := service.GetRuntimeImageForImage("openclaw", defaultShellSystemImageSettings["openclaw"])
	if !ok {
		t.Fatalf("expected default openclaw shell runtime image to resolve")
	}
	if selection.RuntimeType != "shell" {
		t.Fatalf("expected runtime type shell, got %q", selection.RuntimeType)
	}
	if selection.Image != defaultShellSystemImageSettings["openclaw"] {
		t.Fatalf("expected shell image %q, got %q", defaultShellSystemImageSettings["openclaw"], selection.Image)
	}
}

func TestSystemImageSettingServiceGetRuntimeImageForImageUsesCardRuntimeType(t *testing.T) {
	repo := &stubSystemImageSettingRepository{
		items: []models.SystemImageSetting{
			{ID: 1, InstanceType: "openclaw", RuntimeType: "desktop", DisplayName: "OpenClaw Desktop", Image: "registry/openclaw-desktop:latest", IsEnabled: true},
			{ID: 2, InstanceType: "openclaw", RuntimeType: "shell", DisplayName: "OpenClaw Shell", Image: "registry/openclaw-shell:latest", IsEnabled: true},
		},
		nextID: 2,
	}

	service := NewSystemImageSettingService(repo)
	selection, ok := service.GetRuntimeImageForImage("openclaw", "registry/openclaw-shell:latest")
	if !ok {
		t.Fatalf("expected selected shell runtime image to resolve")
	}
	if selection.RuntimeType != "shell" {
		t.Fatalf("expected runtime type shell, got %q", selection.RuntimeType)
	}
	if selection.Image != "registry/openclaw-shell:latest" {
		t.Fatalf("expected shell image to resolve, got %q", selection.Image)
	}
}