The new test_mcp_list test (added in this PR) exposed a latent bug:
check_mcp_server_installed() spawns 'claude mcp list' but only caught
TimeoutExpired/SubprocessError, not FileNotFoundError. On machines
without the claude CLI (e.g. CI) the call raised FileNotFoundError and
crashed 'superclaude mcp --list'. Add FileNotFoundError to the except,
matching the pattern already used by check_docker_available() and the
prerequisite checks in this file.
Also apply ruff format to files this PR introduced/modified:
confidence.py, test_cli_e2e.py, test_execution_init.py.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Complete the confidence-check skill's TypeScript implementation (4 of its 5
checks were placeholder stubs that only read context flags) and enrich the
Python ConfidenceChecker with real tech-stack detection, architecture
anti-pattern warnings, and multi-language duplicate search.
Logic is ported from the kazukinakai fork. The dead airis-agent import layer
from the fork is intentionally dropped: the checks work with zero optional
dependencies, and each check still honors its explicit *_complete / *_verified
context-flag override for testing and pre-checked scenarios.
- confidence.ts: implement noDuplicates / architectureCompliant /
hasOssReference / rootCauseIdentified with project scanning, CLAUDE.md
tech-stack parsing, and regex-based uncertainty detection. Synced across all
four tracked skill copies (src CLI source, plugin source, repo-root, .claude).
- confidence.py: add _read_tech_stack and _check_architecture_anti_patterns;
multi-language (py/ts/js) + content-grep _search_codebase; richer root-cause
validation. Flat single-class structure preserved; accepts both upstream
(target_name/root_cause) and fork (feature_name/proposed_technology) keys.
- tests: add test_cli_main, test_doctor, test_execution_init, test_install_mcp,
test_install_skill, e2e/test_cli_e2e; expand test_confidence to a superset.
All ported tests pass against the existing upstream modules. fork-only
init/check CLI tests and circular full-suite meta-tests were excluded.
NOTE: the confidence-check skill is duplicated across four tracked locations;
a follow-up should collapse these to a single source.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
kazuki