// Licensed to the LF AI & Data foundation under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The ASF licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you may not use this file except in compliance // with the License. You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. package datacoord import ( "context" "fmt" "time" "github.com/cockroachdb/errors" "github.com/samber/lo" "go.uber.org/atomic" "google.golang.org/protobuf/proto" "github.com/milvus-io/milvus/internal/compaction" "github.com/milvus-io/milvus/internal/datacoord/allocator" "github.com/milvus-io/milvus/internal/datacoord/session" "github.com/milvus-io/milvus/internal/metastore/kv/binlog" "github.com/milvus-io/milvus/pkg/v3/mlog" "github.com/milvus-io/milvus/pkg/v3/proto/datapb" "github.com/milvus-io/milvus/pkg/v3/taskcommon" "github.com/milvus-io/milvus/pkg/v3/util/merr" "github.com/milvus-io/milvus/pkg/v3/util/paramtable" ) var _ CompactionTask = (*bumpSchemaVersionTask)(nil) type bumpSchemaVersionTask struct { taskProto atomic.Value // *datapb.CompactionTask allocator allocator.Allocator meta CompactionMeta ievm IndexEngineVersionManager times *taskcommon.Times } func newBumpSchemaVersionTask(t *datapb.CompactionTask, allocator allocator.Allocator, meta CompactionMeta, ievm IndexEngineVersionManager) *bumpSchemaVersionTask { task := &bumpSchemaVersionTask{ allocator: allocator, meta: meta, ievm: ievm, times: taskcommon.NewTimes(), } task.taskProto.Store(t) return task } func (t *bumpSchemaVersionTask) GetTaskID() int64 { return t.GetTaskProto().GetPlanID() } func (t *bumpSchemaVersionTask) GetTaskType() taskcommon.Type { return taskcommon.Compaction } func (t *bumpSchemaVersionTask) GetTaskState() taskcommon.State { return taskcommon.FromCompactionState(t.GetTaskProto().GetState()) } func (t *bumpSchemaVersionTask) GetTaskProto() *datapb.CompactionTask { return t.taskProto.Load().(*datapb.CompactionTask) } func (t *bumpSchemaVersionTask) GetTaskSlot() int64 { return paramtable.Get().DataCoordCfg.BumpSchemaVersionCompactionSlotUsage.GetAsInt64() } func (t *bumpSchemaVersionTask) SetTaskTime(timeType taskcommon.TimeType, time time.Time) { t.times.SetTaskTime(timeType, time) } func (t *bumpSchemaVersionTask) GetTaskTime(timeType taskcommon.TimeType) time.Time { return timeType.GetTaskTime(t.times) } func (t *bumpSchemaVersionTask) GetTaskVersion() int64 { return int64(t.GetTaskProto().GetRetryTimes()) } func (t *bumpSchemaVersionTask) BuildCompactionRequest() (*datapb.CompactionPlan, error) { taskProto := t.GetTaskProto() if taskProto.GetSchema() == nil { return nil, merr.WrapErrIllegalCompactionPlan("schema bump compaction task schema is nil") } compactionParams, err := compaction.GenerateJSONParams(taskProto.GetSchema()) if err != nil { return nil, err } plan := &datapb.CompactionPlan{ PlanID: taskProto.GetPlanID(), StartTime: taskProto.GetStartTime(), Type: taskProto.GetType(), Channel: taskProto.GetChannel(), CollectionTtl: taskProto.GetCollectionTtl(), TotalRows: taskProto.GetTotalRows(), Schema: taskProto.GetSchema(), PreAllocatedSegmentIDs: taskProto.GetPreAllocatedSegmentIDs(), SlotUsage: t.GetSlotUsage(), MaxSize: taskProto.GetMaxSize(), JsonParams: compactionParams, CurrentScalarIndexVersion: t.ievm.GetCurrentScalarIndexEngineVersion(), } segments := make([]*SegmentInfo, 0, len(taskProto.GetInputSegments())) for _, segID := range taskProto.GetInputSegments() { segInfo := t.meta.GetHealthySegment(context.TODO(), segID) if segInfo == nil { return nil, merr.WrapErrSegmentNotFound(segID) } plan.SegmentBinlogs = append(plan.SegmentBinlogs, &datapb.CompactionSegmentBinlogs{ SegmentID: segID, CollectionID: segInfo.GetCollectionID(), PartitionID: segInfo.GetPartitionID(), Level: segInfo.GetLevel(), InsertChannel: segInfo.GetInsertChannel(), FieldBinlogs: segInfo.GetBinlogs(), Field2StatslogPaths: segInfo.GetStatslogs(), Deltalogs: segInfo.GetDeltalogs(), IsSorted: segInfo.GetIsSorted(), IsSortedByNamespace: segInfo.GetIsSortedByNamespace(), StorageVersion: segInfo.GetStorageVersion(), Manifest: segInfo.GetManifestPath(), CommitTimestamp: segInfo.GetCommitTimestamp(), }) segments = append(segments, segInfo) } logIDRange, err := PreAllocateBinlogIDs(t.allocator, segments, taskProto.GetSchema()) if err != nil { return nil, err } plan.PreAllocatedLogIDs = logIDRange plan.BeginLogID = logIDRange.Begin WrapPluginContext(taskProto.GetCollectionID(), taskProto.GetSchema().GetProperties(), plan) return plan, nil } func (t *bumpSchemaVersionTask) GetSlotUsage() int64 { return t.GetTaskSlot() } func (t *bumpSchemaVersionTask) GetLabel() string { return fmt.Sprintf("%d-%s", t.GetTaskProto().GetPartitionID(), t.GetTaskProto().GetChannel()) } func (t *bumpSchemaVersionTask) SetTask(task *datapb.CompactionTask) { t.taskProto.Store(task) } func (t *bumpSchemaVersionTask) ShadowClone(opts ...compactionTaskOpt) *datapb.CompactionTask { cloned := proto.Clone(t.GetTaskProto()).(*datapb.CompactionTask) for _, opt := range opts { opt(cloned) } return cloned } func (t *bumpSchemaVersionTask) SetNodeID(nodeID int64) error { return t.updateAndSaveTaskMeta(setNodeID(nodeID)) } func (t *bumpSchemaVersionTask) NeedReAssignNodeID() bool { return t.GetTaskProto().GetState() == datapb.CompactionTaskState_pipelining && (t.GetTaskProto().GetNodeID() == 0 || t.GetTaskProto().GetNodeID() == NullNodeID) } func (t *bumpSchemaVersionTask) saveTaskMeta(task *datapb.CompactionTask) error { return t.meta.SaveCompactionTask(context.TODO(), task) } func (t *bumpSchemaVersionTask) SaveTaskMeta() error { return t.saveTaskMeta(t.GetTaskProto()) } func (t *bumpSchemaVersionTask) Clean() bool { return t.doClean() == nil } func (t *bumpSchemaVersionTask) doClean() error { log := mlog.With(mlog.Int64("triggerID", t.GetTaskProto().GetTriggerID()), mlog.Int64("PlanID", t.GetTaskProto().GetPlanID()), mlog.FieldCollectionID(t.GetTaskProto().GetCollectionID())) err := t.updateAndSaveTaskMeta(setState(datapb.CompactionTaskState_cleaned)) if err != nil { log.Warn(context.TODO(), "bumpSchemaVersionTask fail to updateAndSaveTaskMeta", mlog.Err(err)) return err } // resetSegmentCompacting must be the last step of Clean, to make sure resetSegmentCompacting only called once // otherwise, it may unlock segments locked by other compaction tasks t.resetSegmentCompacting() log.Info(context.TODO(), "bumpSchemaVersionTask clean done") return nil } func (t *bumpSchemaVersionTask) resetSegmentCompacting() { t.meta.SetSegmentsCompacting(context.TODO(), t.GetTaskProto().GetInputSegments(), false) } func (t *bumpSchemaVersionTask) processFailed() bool { return true } func (t *bumpSchemaVersionTask) CreateTaskOnWorker(nodeID int64, cluster session.Cluster) { log := mlog.With(mlog.Int64("triggerID", t.GetTaskProto().GetTriggerID()), mlog.Int64("PlanID", t.GetTaskProto().GetPlanID()), mlog.FieldCollectionID(t.GetTaskProto().GetCollectionID()), mlog.FieldNodeID(nodeID)) plan, err := t.BuildCompactionRequest() if err != nil { log.Warn(context.TODO(), "bumpSchemaVersionTask failed to build compaction request", mlog.Err(err)) err = t.updateAndSaveTaskMeta(setState(datapb.CompactionTaskState_failed), setFailReason(err.Error())) if err != nil { log.Warn(context.TODO(), "bumpSchemaVersionTask failed to updateAndSaveTaskMeta", mlog.Err(err)) } return } err = cluster.CreateCompaction(nodeID, plan, t.GetTaskProto().GetCollectionID()) if err != nil { log.Warn(context.TODO(), "bumpSchemaVersionTask failed to notify compaction tasks to DataNode", mlog.Int64("planID", t.GetTaskProto().GetPlanID()), mlog.FieldNodeID(nodeID), mlog.Err(err)) err = t.updateAndSaveTaskMeta(setState(datapb.CompactionTaskState_pipelining), setNodeID(NullNodeID)) if err != nil { log.Warn(context.TODO(), "bumpSchemaVersionTask failed to updateAndSaveTaskMeta", mlog.Err(err)) } return } log.Info(context.TODO(), "bumpSchemaVersionTask created task on worker", mlog.Int64("planID", t.GetTaskProto().GetPlanID()), mlog.FieldNodeID(nodeID)) err = t.updateAndSaveTaskMeta(setState(datapb.CompactionTaskState_executing), setNodeID(nodeID)) if err != nil { log.Warn(context.TODO(), "bumpSchemaVersionTask failed to updateAndSaveTaskMeta", mlog.Err(err)) } } func (t *bumpSchemaVersionTask) QueryTaskOnWorker(cluster session.Cluster) { log := mlog.With(mlog.Int64("triggerID", t.GetTaskProto().GetTriggerID()), mlog.Int64("PlanID", t.GetTaskProto().GetPlanID()), mlog.FieldCollectionID(t.GetTaskProto().GetCollectionID())) result, err := cluster.QueryCompaction(t.GetTaskProto().GetNodeID(), &datapb.CompactionStateRequest{ PlanID: t.GetTaskProto().GetPlanID(), }) if err != nil || result == nil { if errors.Is(err, merr.ErrNodeNotFound) { if err := t.updateAndSaveTaskMeta(setState(datapb.CompactionTaskState_pipelining), setNodeID(NullNodeID)); err != nil { log.Warn(context.TODO(), "bumpSchemaVersionTask failed to updateAndSaveTaskMeta", mlog.Err(err)) } } log.Warn(context.TODO(), "bumpSchemaVersionTask failed to get compaction result", mlog.Err(err)) return } switch result.GetState() { case datapb.CompactionTaskState_completed: if len(result.GetSegments()) == 0 { log.Warn(context.TODO(), "bumpSchemaVersionTask illegal compaction results: no segments returned") if err := t.updateAndSaveTaskMeta(setState(datapb.CompactionTaskState_failed), setFailReason("illegal compaction results: no segments returned")); err != nil { log.Warn(context.TODO(), "bumpSchemaVersionTask failed to setState failed", mlog.Err(err)) } return } err = t.meta.ValidateSegmentStateBeforeCompleteCompactionMutation(t.GetTaskProto()) if err != nil { if saveErr := t.updateAndSaveTaskMeta(setState(datapb.CompactionTaskState_failed), setFailReason(err.Error())); saveErr != nil { log.Warn(context.TODO(), "bumpSchemaVersionTask failed to setState failed", mlog.Err(saveErr)) } return } if err := t.saveSegmentMeta(result); err != nil { log.Warn(context.TODO(), "bumpSchemaVersionTask failed to save segment meta", mlog.Err(err)) if errors.Is(err, merr.ErrIllegalCompactionPlan) { if saveErr := t.updateAndSaveTaskMeta(setState(datapb.CompactionTaskState_failed), setFailReason(err.Error())); saveErr != nil { log.Warn(context.TODO(), "bumpSchemaVersionTask failed to setState failed", mlog.Err(saveErr)) } } return } UpdateCompactionSegmentSizeMetrics(result.GetSegments()) t.processMetaSaved() case datapb.CompactionTaskState_pipelining, datapb.CompactionTaskState_executing: return case datapb.CompactionTaskState_timeout: err = t.updateAndSaveTaskMeta(setState(datapb.CompactionTaskState_timeout)) if err != nil { log.Warn(context.TODO(), "bumpSchemaVersionTask failed to updateAndSaveTaskMeta", mlog.Err(err)) return } case datapb.CompactionTaskState_failed: log.Warn(context.TODO(), "bumpSchemaVersionTask fail in datanode") if err := t.updateAndSaveTaskMeta(setState(datapb.CompactionTaskState_failed), setFailReason("compaction failed in datanode")); err != nil { log.Warn(context.TODO(), "bumpSchemaVersionTask failed to updateAndSaveTaskMeta", mlog.Err(err)) } default: log.Error(context.TODO(), "not support compaction task state", mlog.String("state", result.GetState().String())) reason := fmt.Sprintf("unsupported compaction state: %s", result.GetState().String()) if err = t.updateAndSaveTaskMeta(setState(datapb.CompactionTaskState_failed), setFailReason(reason)); err != nil { log.Warn(context.TODO(), "bumpSchemaVersionTask failed to updateAndSaveTaskMeta", mlog.Err(err)) return } } } func (t *bumpSchemaVersionTask) DropTaskOnWorker(cluster session.Cluster) { log := mlog.With(mlog.Int64("triggerID", t.GetTaskProto().GetTriggerID()), mlog.Int64("PlanID", t.GetTaskProto().GetPlanID()), mlog.FieldCollectionID(t.GetTaskProto().GetCollectionID())) if err := cluster.DropCompaction(t.GetTaskProto().GetNodeID(), t.GetTaskProto().GetPlanID()); err != nil { log.Warn(context.TODO(), "bumpSchemaVersionTask unable to drop compaction plan", mlog.Err(err)) } } // Process performs the task's state machine // Note: return True means exit this state machine. // ONLY return True for Completed, Failed, Timeout func (t *bumpSchemaVersionTask) Process() bool { log := mlog.With(mlog.Int64("triggerID", t.GetTaskProto().GetTriggerID()), mlog.Int64("PlanID", t.GetTaskProto().GetPlanID()), mlog.FieldCollectionID(t.GetTaskProto().GetCollectionID())) lastState := t.GetTaskProto().GetState().String() processResult := false switch t.GetTaskProto().GetState() { case datapb.CompactionTaskState_meta_saved: processResult = t.processMetaSaved() case datapb.CompactionTaskState_completed: processResult = t.processCompleted() case datapb.CompactionTaskState_failed: processResult = t.processFailed() case datapb.CompactionTaskState_timeout: processResult = true } currentState := t.GetTaskProto().GetState().String() if currentState != lastState { log.Info(context.TODO(), "schema bump compaction task state changed", mlog.String("lastState", lastState), mlog.String("currentState", currentState)) } return processResult } func (t *bumpSchemaVersionTask) saveSegmentMeta(result *datapb.CompactionPlanResult) error { log := mlog.With(mlog.Int64("triggerID", t.GetTaskProto().GetTriggerID()), mlog.Int64("PlanID", t.GetTaskProto().GetPlanID()), mlog.FieldCollectionID(t.GetTaskProto().GetCollectionID())) if err := binlog.CompressCompactionBinlogs(result.GetSegments()); err != nil { return err } newSegments, metricMutation, err := t.meta.CompleteCompactionMutation(context.TODO(), t.GetTaskProto(), result) if err != nil { return err } newSegmentIDs := lo.Map(newSegments, func(s *SegmentInfo, _ int) UniqueID { return s.GetID() }) metricMutation.commit() for _, newSegID := range newSegmentIDs { select { case getBuildIndexChSingleton() <- newSegID: default: } } err = t.updateAndSaveTaskMeta(setState(datapb.CompactionTaskState_meta_saved), setResultSegments(newSegmentIDs)) if err != nil { log.Warn(context.TODO(), "bumpSchemaVersionTask failed to setState meta saved", mlog.Err(err)) return err } log.Info(context.TODO(), "bumpSchemaVersionTask success to save segment meta") return nil } func (t *bumpSchemaVersionTask) processMetaSaved() bool { err := t.updateAndSaveTaskMeta(setState(datapb.CompactionTaskState_completed)) if err != nil { mlog.Warn(context.TODO(), "bumpSchemaVersionTask unable to processMetaSaved", mlog.Int64("planID", t.GetTaskProto().GetPlanID()), mlog.Err(err)) return false } return t.processCompleted() } func (t *bumpSchemaVersionTask) processCompleted() bool { log := mlog.With(mlog.Int64("triggerID", t.GetTaskProto().GetTriggerID()), mlog.Int64("PlanID", t.GetTaskProto().GetPlanID()), mlog.FieldCollectionID(t.GetTaskProto().GetCollectionID())) log.Info(context.TODO(), "bumpSchemaVersionTask processCompleted done") return true } func (t *bumpSchemaVersionTask) updateAndSaveTaskMeta(opts ...compactionTaskOpt) error { // if task state is completed, cleaned, failed, timeout, then do append end time and save if t.GetTaskProto().State == datapb.CompactionTaskState_completed || t.GetTaskProto().State == datapb.CompactionTaskState_cleaned || t.GetTaskProto().State == datapb.CompactionTaskState_failed || t.GetTaskProto().State == datapb.CompactionTaskState_timeout { ts := time.Now().Unix() opts = append(opts, setEndTime(ts)) } task := t.ShadowClone(opts...) err := t.saveTaskMeta(task) if err != nil { return err } t.SetTask(task) return nil }