项目文件夹

文件
Copilot 50ce1a5e83 TLS certificate verification: opt-in security to preserve backward compatibility (#2843)
* Initial plan

* Fix insecure TLS configuration - make secure by default

- Changed util/tls/Config() to be secure by default (InsecureSkipVerify=false)
- Added MICRO_TLS_INSECURE=true environment variable for development/testing
- Updated documentation to emphasize security-first approach
- Added comprehensive tests for TLS configuration
- All existing broker tests pass

Co-authored-by: asim <17530+asim@users.noreply.github.com>

* Revert to backward-compatible TLS defaults to avoid breaking changes

- Reverted default to InsecureSkipVerify=true for backward compatibility
- Changed environment variable to MICRO_TLS_SECURE=true (opt-in security)
- Added deprecation warning that logs once per process
- Updated tests to reflect backward-compatible behavior
- Added comprehensive migration guide
- No breaking changes - production systems safe to upgrade
- Security improvement is opt-in via environment variable
- Planned breaking change for v6 with proper major version bump

Co-authored-by: asim <17530+asim@users.noreply.github.com>

* Add TLS security update documentation

Co-authored-by: asim <17530+asim@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: asim <17530+asim@users.noreply.github.com>
2026-02-03 15:53:03 +00:00

104 行
2.3 KiB
Go

package tls
import (
"os"
"testing"
)
func TestConfig(t *testing.T) {
tests := []struct {
name string
envVar string
envValue string
wantInsecure bool
description string
}{
{
name: "default_insecure_for_backward_compatibility",
envVar: "",
envValue: "",
wantInsecure: true,
description: "Default should remain insecure for backward compatibility (will change in v6)",
},
{
name: "secure_mode_enabled",
envVar: "MICRO_TLS_SECURE",
envValue: "true",
wantInsecure: false,
description: "MICRO_TLS_SECURE=true should enable certificate verification",
},
{
name: "secure_mode_disabled",
envVar: "MICRO_TLS_SECURE",
envValue: "false",
wantInsecure: true,
description: "MICRO_TLS_SECURE=false should remain insecure",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// Clean up environment
os.Unsetenv("MICRO_TLS_SECURE")
os.Unsetenv("MICRO_TLS_INSECURE")
// Suppress warning in tests
os.Setenv("IN_TRAVIS_CI", "yes")
defer os.Unsetenv("IN_TRAVIS_CI")
// Set environment variable if specified
if tt.envVar != "" {
os.Setenv(tt.envVar, tt.envValue)
defer os.Unsetenv(tt.envVar)
}
config := Config()
if config == nil {
t.Fatal("Config() returned nil")
}
if config.InsecureSkipVerify != tt.wantInsecure {
t.Errorf("%s: InsecureSkipVerify = %v, want %v",
tt.description, config.InsecureSkipVerify, tt.wantInsecure)
}
// Verify MinVersion is set correctly
if config.MinVersion == 0 {
t.Error("MinVersion should be set")
}
})
}
}
func TestSecureConfig(t *testing.T) {
config := SecureConfig()
if config == nil {
t.Fatal("SecureConfig() returned nil")
}
if config.InsecureSkipVerify {
t.Error("SecureConfig should have InsecureSkipVerify set to false")
}
if config.MinVersion == 0 {
t.Error("MinVersion should be set")
}
}
func TestInsecureConfig(t *testing.T) {
config := InsecureConfig()
if config == nil {
t.Fatal("InsecureConfig() returned nil")
}
if !config.InsecureSkipVerify {
t.Error("InsecureConfig should have InsecureSkipVerify set to true")
}
if config.MinVersion == 0 {
t.Error("MinVersion should be set")
}
}