3e885308a0
lint: clear the golangci-lint backlog and enforce a blocking lint in CI ( #2995 )
...
Fixes #2988 . Brings 'golangci-lint run ./...' to zero issues (was ~373):
- errcheck: explicitly ignore fire-and-forget calls with '_ =' (and a small
errcheck.exclude-functions list for response writes — json Encoder.Encode,
http ResponseWriter.Write, fmt.Fprint*); genuine cases handled.
- unused: remove dead code (unexported decls and dead test helpers) and the
imports they orphaned.
- staticcheck: ST1005 error strings, ST1016 receiver names, S1000/S1017/S1019/
S1023 simplifications, SA4004/SA4006/SA4010 dead code, SA1021 net.IP.Equal,
SA6002 (store *[]byte in sync.Pool).
- govet: fix a context leak (lostcancel) in internal/util/mdns and move
t.Fatal/Fatalf out of goroutines (testinggoroutine) in tests.
- ineffassign, unconvert: mechanical fixes.
CI: the Lint workflow now runs a blocking full-tree 'golangci-lint run' on
pushes and PRs (dropped only-new-issues now that the tree is clean).
Verified: go build, go vet, test compilation, and unit tests for the
behaviourally-touched packages all pass.
Claude-Session: https://claude.ai/code/session_01CmdEY7pYmV5zzwCjNJ4ykL
Co-authored-by: Claude <noreply@anthropic.com >
2026-06-22 18:51:30 +01:00
4ba40ea579
Replace custom logger with log/slog ( #2844 )
...
* Initial plan
* Replace custom logger with slog implementation
Co-authored-by: asim <17530+asim@users.noreply.github.com >
* Fix linting issues in slog implementation
Co-authored-by: asim <17530+asim@users.noreply.github.com >
* Address code review feedback: fix locking and use copyFields
Co-authored-by: asim <17530+asim@users.noreply.github.com >
* Restore debug/log buffer functionality with slog
Co-authored-by: asim <17530+asim@users.noreply.github.com >
* Address code review feedback: extract helper and remove dead code
Co-authored-by: asim <17530+asim@users.noreply.github.com >
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: asim <17530+asim@users.noreply.github.com >
2026-02-03 15:55:46 +00:00
85c0b0b8eb
fix: some linting issues ( #2563 )
2022-09-30 16:27:07 +02:00
3543b275e0
fix log level helper ( #1342 )
...
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org >
2020-03-13 17:36:42 +03:00
241614ff68
add helper function to determine logger level ( #1321 )
...
* add helper function to determine logger level
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org >
2020-03-09 23:43:05 +03:00
e3ce45495a
os.Exit on log.Fatal ( #1316 )
...
* os.Exit on log.Fatal
* Fix TestOptions
Co-authored-by: Ben Toogood <ben@micro.mu >
2020-03-09 09:23:42 +00:00
64a5ce9607
various fixes ( #1267 )
...
* logger: remove Panic log level
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org >
* server/grpc: add missing Unlock in Subscribe error
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org >
* server: minor code change
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org >
* server/grpc: extend test suite with pub/sub testing
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org >
* server/grpc: fix invalid check and allow subscriber error to be returned
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org >
* server/grpc: add pubsub tests
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org >
* client/grpc: check for nil req/rsp
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org >
2020-02-26 18:34:40 +00:00
53c3bff819
add Panic & Panicf to logger ( #1258 )
...
* add Panic & Panicf to logger
2020-02-25 17:44:29 +03:00
116855572b
Add log level helper funtions ( #1229 )
2020-02-21 08:43:23 +00:00
3fa7c26946
logger with helper methods ( #1216 )
...
* support unix daemon socket
* refactor(logger): logger fields changed to map[string]interface{}
* improvement(logger): adding string to Level Parser
* improvement(logger): rename ParseLevel to GetLevel
* refactor(logger): adding basic logger
adding micro default logger, and refactor logger interface
* refactor(logger): moved basic logger to top level package
* refactor(logger): adding default logger
2020-02-21 07:57:59 +00:00
fc5339a368
[W.I.P] refactor(logger): logger fields changed to map[string]interface{} ( #1198 )
...
* support unix daemon socket
* refactor(logger): logger fields changed to map[string]interface{}
* improvement(logger): adding string to Level Parser
* improvement(logger): rename ParseLevel to GetLevel
2020-02-15 18:19:28 +00:00
fdfb2bc4c1
[WIP] logger first ( #1161 )
...
* logger first
* log->logger
* update comment
* add context in Options
* add Fields
* remove logfi
* add field encode
* add common Field Types
* update logger field
2020-02-06 21:35:46 +00:00
Asim Aslam