020b15ad77
small more fixes
Andrej Karpathy
2024-06-03 19:32:32 +00:00
5d9403479c
some fixes, still not done
Andrej Karpathy
2024-06-03 18:50:41 +00:00
804d0693c8
refactor part 2, moving stuff into common files so that we can later nicely separate out all the kernels as well
Andrej Karpathy
2024-06-03 18:10:33 +00:00
e40268457f
Merge pull request #526 from karpathy/try/move_cudnn_to_llmc
Andrej
2024-06-03 09:32:31 -07:00
0d16b51626
more efficient use of memory buffers for LN recomputation
Erik Schultheis
2024-06-03 18:19:52 +03:00
761fb2cf2b
rename gelu_backward to gelu_backward_inplace, and made it obvious in the code that this is an inplace operation
Erik Schultheis
2024-06-01 14:31:26 +03:00
cc4bed0806
added missing checks
Erik Schultheis
2024-06-01 14:30:40 +03:00
9c8edaffa7
fix recompute bug
Andrej Karpathy
2024-05-31 22:38:03 +00:00
0bc24c36e6
fix bug in resumption of dataloader, have to reload shard
Andrej Karpathy
2024-05-31 22:19:37 +00:00
1de3bef0ac
fix argparse comment too
Andrej Karpathy
2024-05-31 22:06:48 +00:00
60a1037db9
Merge branch 'ChrisDryden-layernorm_backwards_mem_saving'
Andrej Karpathy
2024-05-31 22:04:44 +00:00
f4874a9f63
make things a bit more consistent, keep recompute 1 as default, and add a comment
Andrej Karpathy
2024-05-31 22:04:34 +00:00
629a24020d
Merge branch 'layernorm_backwards_mem_saving' of https://github.com/ChrisDryden/llm.c into ChrisDryden-layernorm_backwards_mem_saving
Andrej Karpathy
2024-05-31 21:47:28 +00:00
ed37d9261b
fix bug in readme
Andrej Karpathy
2024-05-30 21:39:47 +00:00
b48224cb0c
refactor the README file because it was getting crazy
Andrej Karpathy
2024-05-30 21:39:06 +00:00
0fddf06043
more docs on scripts
Andrej Karpathy
2024-05-30 21:06:36 +00:00
fe36e40f2c
also move pyrun script to scripts/
Andrej Karpathy
2024-05-30 20:17:16 +00:00
d98d3ed82b
code refactor, introduce llmc dir and scripts dir
Andrej
2024-05-30 13:13:04 -07:00
22d1607f6d
delete these files, they are now in scripts/ folder and better
feature/libdir
Andrej Karpathy
2024-05-30 20:11:59 +00:00
fc40ffc4aa
adjust readme to new scripts/ dir
Andrej Karpathy
2024-05-30 20:10:04 +00:00
a0d5dbbda6
scripts folder
Andrej Karpathy
2024-05-30 20:00:07 +00:00
35aa110244
more refactor
Andrej Karpathy
2024-05-30 19:39:29 +00:00
f8f9e49ba3
Merge branch 'master' into feature/libdir
Andrej Karpathy
2024-05-30 19:07:51 +00:00
5f547601a0
further hide the c pytorch bridge logic
Andrej Karpathy
2024-05-30 18:20:29 +00:00
ca27eb8fa5
bugfix don't train on val batch
Andrej Karpathy
2024-05-30 18:18:05 +00:00
59432fea19
modified the recalculation parameter to be based off of 2 instead of 1
Christopher
2024-05-30 17:23:47 +00:00
e5719e18b3
Rearranged layernorm forward for 1 and 2 and used layer variables instead. Validated with test file
Christopher
2024-05-30 02:19:52 +00:00
95b1fad088
First step in creating option to recalculate layernorm activations in backwards pass
Christopher
2024-05-28 02:04:23 +00:00
0e2298247a
Merge pull request #496 from ChrisDryden/patch-7
Andrej
2024-05-30 09:13:30 -07:00
862c957d3a
fix default number of gpus from 4 to 8 for consistency with run124M.sh
Andrej Karpathy
2024-05-30 14:50:09 +00:00
ed805f60be
Merge pull request #494 from karpathy/feature/pytorch_parity
Andrej
2024-05-30 07:47:58 -07:00
9b935a8f04
fix bug with advancing position in dataloader
Andrej Karpathy
2024-05-30 13:16:07 +00:00
3bca31fde1
Nit: duplicated line in header of project
Chris Dryden
2024-05-29 20:03:13 -07:00
5450632237
Removed unnecesary shared memory due to blockreduce using static defined shared memory
Christopher
2024-05-30 03:01:52 +00:00
555d07502a
more feature parity work, i think it's quite close now
Andrej Karpathy
2024-05-30 02:29:40 +00:00
ea88a343b5
also updated pyrun124M.sh
Andrej Karpathy
2024-05-30 02:05:41 +00:00
03c2e85601
sharded dataloader for PyTorch
Andrej Karpathy
2024-05-30 02:05:06 +00:00
3fdf88e4d4
add logfile similar to C
Andrej Karpathy
2024-05-29 23:59:35 +00:00
083c50a52e
small stylistic touchups that match the c code
Andrej Karpathy
2024-05-29 23:50:13 +00:00
1f6fdfbd9a
add pyrun124M.sh
Andrej Karpathy
2024-05-29 23:30:27 +00:00
c413bfe0ca
pytorch parity v1
Andrej Karpathy
2024-05-29 23:25:55 +00:00
4cc8b1570b
hardcode grad_clip to 1.0, delete confusion around legacy code that used -c flag for it, but became inactive in the if else block
Andrej Karpathy
2024-05-29 19:01:12 +00:00
55f3665b64
Merge pull request #493 from vyom1611/master-2
Andrej
2024-05-29 07:50:10 -07:00