alishahryar1--free-claude-code
85b601884d
## Problem Python 3.14 provides native lazy annotations, but the codebase still relied on legacy future annotation imports. Those imports also made type-only import cycles easier to hide instead of fixing ownership boundaries. ## Changes | Before | After | | --- | --- | | Python files used `from __future__ import annotations`. | Python files rely on Python 3.14 native lazy annotations. | | Some runtime modules used `TYPE_CHECKING` or local imports for required dependencies. | Runtime modules use top-level owner-module imports with explicit boundaries. | | Local and GitHub guardrails only rejected type ignore suppressions. | Local and GitHub guardrails reject type ignore suppressions and legacy future annotation imports. | | Agent docs only documented the no-type-ignore rule. | Agent docs document the Python 3.14 annotation and import-boundary rules. | <!-- greptile_comment --> <details open><summary><h3>Greptile Summary</h3></summary> This PR moves the codebase to Python 3.14 native lazy annotations. The main changes are: - Removed legacy `from __future__ import annotations` imports across Python modules. - Promoted selected runtime dependencies from `TYPE_CHECKING` or local imports to explicit owner-module imports. - Added local, GitHub, and contract-test guardrails to reject legacy future annotation imports. - Updated agent docs with the annotation and import-boundary rules. - Bumped the package patch version for production-file changes. </details> <h3>Confidence Score: 5/5</h3> Safe to merge with low risk. The changes are mostly mechanical annotation cleanup with matching CI and contract-test guardrails. Reviewed import-boundary updates did not show a confirmed runtime cycle or dependency break. No files require special attention. <details><summary><h3><a href="https://www.greptile.com/trex"><img alt="T-Rex" src="https://greptile-static-assets.s3.amazonaws.com/trex/trex_green.svg" height="20" align="absmiddle"></a> T-Rex Logs</h3></summary> **What T-Rex did** - Performed an end-to-end validation of the guardrail contract suite: an environment check confirmed uv availability, a guardrail pytest run used CPython 3.14.0 with 5 passing contract tests, 3 focused CI-script tests passed, and the direct CI suppressions guardrail command (including the legacy future-annotations grep) also passed. <a href="https://app.greptile.com/trex/runs/13303335/artifacts"><picture><source media="(prefers-color-scheme: dark)" srcset="https://greptile-static-assets.s3.amazonaws.com/badges/ViewAllArtifactsDark.svg?v=4"><source media="(prefers-color-scheme: light)" srcset="https://greptile-static-assets.s3.amazonaws.com/badges/ViewAllArtifacts.svg?v=4"><img alt="View all artifacts" src="https://greptile-static-assets.s3.amazonaws.com/badges/ViewAllArtifacts.svg?v=4"></picture></a> <sub><a href="https://www.greptile.com/trex"><img alt="T-Rex" src="https://greptile-static-assets.s3.amazonaws.com/trex/trex_green.svg" height="14" align="absmiddle"></a> Ran code and verified through T-Rex</sub> </details> <details open><summary><h3>Important Files Changed</h3></summary> | Filename | Overview | |----------|----------| | api/runtime.py | Moves messaging, CLI manager, session, limiter, and tree dependencies from local/type-checking imports to explicit top-level owner-module imports. | | messaging/platforms/telegram.py | Removes future annotations and promotes Telegram SDK type imports into the existing availability guard. | | messaging/platforms/telegram_inbound.py | Removes future annotations and imports Telegram SDK types at module scope for inbound normalization. | | tests/contracts/test_import_boundaries.py | Adds an AST contract that rejects legacy future annotation imports across Python files. | | scripts/ci.sh | Extends the local suppression check to reject legacy future annotation imports alongside type-ignore suppressions. | | scripts/ci.ps1 | Mirrors the local PowerShell CI suppression check for legacy future annotations. | | .github/workflows/tests.yml | Renames and broadens the GitHub guardrail job to reject both type suppressions and legacy future annotations. | | pyproject.toml | Bumps the patch version for production-file changes. | </details> <details open><summary><h3>Sequence Diagram</h3></summary> <a href="#gh-light-mode-only"> ```mermaid %%{init: {'theme': 'neutral'}}%% sequenceDiagram participant Dev as Developer/CI participant Guard as Suppression guard participant AST as Import-boundary contract test participant Py as Python modules Dev->>Guard: Run local/GitHub suppression check Guard->>Py: "Scan *.py for type ignores and future annotations" Guard-->>Dev: Fail if legacy annotation import remains Dev->>AST: Run pytest contract tests AST->>Py: Parse imports with ast AST-->>Dev: Assert no future annotations/import-boundary violations Py-->>Dev: Use Python 3.14 native lazy annotations ``` </a> <a href="#gh-dark-mode-only"> ```mermaid %%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% sequenceDiagram participant Dev as Developer/CI participant Guard as Suppression guard participant AST as Import-boundary contract test participant Py as Python modules Dev->>Guard: Run local/GitHub suppression check Guard->>Py: "Scan *.py for type ignores and future annotations" Guard-->>Dev: Fail if legacy annotation import remains Dev->>AST: Run pytest contract tests AST->>Py: Parse imports with ast AST-->>Dev: Assert no future annotations/import-boundary violations Py-->>Dev: Use Python 3.14 native lazy annotations ``` </a> </details> <sub>Reviews (2): Last reviewed commit: ["Remove legacy future annotations import"](https://github.com/alishahryar1/free-claude-code/commit/6e6cda69da243bbdb92831207aecb3731ad469f8) | [Re-trigger Greptile](https://app.greptile.com/api/retrigger?id=41875785)</sub> <!-- /greptile_comment -->
112 行
3.7 KiB
Python
112 行
3.7 KiB
Python
import os
|
|
import time
|
|
|
|
import httpx
|
|
import pytest
|
|
|
|
from smoke.lib.config import SmokeConfig
|
|
|
|
|
|
@pytest.mark.live
|
|
@pytest.mark.smoke_target("telegram")
|
|
def test_telegram_bot_api_permissions(smoke_config: SmokeConfig) -> None:
|
|
token = smoke_config.settings.telegram_bot_token
|
|
if not token:
|
|
pytest.skip("TELEGRAM_BOT_TOKEN is not configured")
|
|
|
|
base_url = f"https://api.telegram.org/bot{token}"
|
|
get_me = httpx.get(f"{base_url}/getMe", timeout=smoke_config.timeout_s)
|
|
assert get_me.status_code == 200, get_me.text
|
|
assert get_me.json()["ok"] is True
|
|
|
|
chat_id = os.getenv("FCC_SMOKE_TELEGRAM_CHAT_ID") or (
|
|
smoke_config.settings.allowed_telegram_user_id or ""
|
|
)
|
|
if not chat_id:
|
|
pytest.skip("FCC_SMOKE_TELEGRAM_CHAT_ID or ALLOWED_TELEGRAM_USER_ID required")
|
|
|
|
marker = f"FCC smoke {int(time.time())}"
|
|
sent = httpx.post(
|
|
f"{base_url}/sendMessage",
|
|
json={"chat_id": chat_id, "text": marker},
|
|
timeout=smoke_config.timeout_s,
|
|
)
|
|
assert sent.status_code == 200, sent.text
|
|
message_id = sent.json()["result"]["message_id"]
|
|
|
|
edited = httpx.post(
|
|
f"{base_url}/editMessageText",
|
|
json={"chat_id": chat_id, "message_id": message_id, "text": marker + " edit"},
|
|
timeout=smoke_config.timeout_s,
|
|
)
|
|
assert edited.status_code == 200, edited.text
|
|
|
|
deleted = httpx.post(
|
|
f"{base_url}/deleteMessage",
|
|
json={"chat_id": chat_id, "message_id": message_id},
|
|
timeout=smoke_config.timeout_s,
|
|
)
|
|
assert deleted.status_code == 200, deleted.text
|
|
|
|
|
|
@pytest.mark.live
|
|
@pytest.mark.smoke_target("discord")
|
|
def test_discord_bot_api_permissions(smoke_config: SmokeConfig) -> None:
|
|
token = smoke_config.settings.discord_bot_token
|
|
channel_id = os.getenv("FCC_SMOKE_DISCORD_CHANNEL_ID")
|
|
if not channel_id and smoke_config.settings.allowed_discord_channels:
|
|
channel_id = smoke_config.settings.allowed_discord_channels.split(",", 1)[0]
|
|
if not token:
|
|
pytest.skip("DISCORD_BOT_TOKEN is not configured")
|
|
if not channel_id:
|
|
pytest.skip("FCC_SMOKE_DISCORD_CHANNEL_ID or ALLOWED_DISCORD_CHANNELS required")
|
|
|
|
headers = {"authorization": f"Bot {token}"}
|
|
base_url = "https://discord.com/api/v10"
|
|
|
|
channel = httpx.get(
|
|
f"{base_url}/channels/{channel_id}",
|
|
headers=headers,
|
|
timeout=smoke_config.timeout_s,
|
|
)
|
|
assert channel.status_code == 200, channel.text
|
|
|
|
marker = f"FCC smoke {int(time.time())}"
|
|
sent = httpx.post(
|
|
f"{base_url}/channels/{channel_id}/messages",
|
|
headers=headers,
|
|
json={"content": marker},
|
|
timeout=smoke_config.timeout_s,
|
|
)
|
|
assert sent.status_code == 200, sent.text
|
|
message_id = sent.json()["id"]
|
|
|
|
edited = httpx.patch(
|
|
f"{base_url}/channels/{channel_id}/messages/{message_id}",
|
|
headers=headers,
|
|
json={"content": marker + " edit"},
|
|
timeout=smoke_config.timeout_s,
|
|
)
|
|
assert edited.status_code == 200, edited.text
|
|
|
|
deleted = httpx.delete(
|
|
f"{base_url}/channels/{channel_id}/messages/{message_id}",
|
|
headers=headers,
|
|
timeout=smoke_config.timeout_s,
|
|
)
|
|
assert deleted.status_code in {200, 204}, deleted.text
|
|
|
|
|
|
@pytest.mark.live
|
|
@pytest.mark.smoke_target("telegram")
|
|
@pytest.mark.smoke_target("discord")
|
|
def test_interactive_inbound_messaging_requires_explicit_mode(
|
|
smoke_config: SmokeConfig,
|
|
) -> None:
|
|
if not smoke_config.interactive:
|
|
pytest.skip("set FCC_SMOKE_INTERACTIVE=1 for manual inbound messaging checks")
|
|
pytest.skip(
|
|
"manual inbound check: start the server, send a nonce from the real client, "
|
|
"and verify threaded progress plus /stop, /clear, and /stats"
|
|
)
|